OpenSolaris

  subsites   code review   repo   packages   bugs   defect   polls   planet
You are not signed in. Sign in or register.

Open HA Cluster Sponsor Tasks

Following are several tasks which sponsors are expected to perform. Note that we hope that many of these tasks will diminish over time, especially those “proxy” operations which currently require SWAN access. Note that, like much of our process, this is shrink-to-fit: many of these tasks are not needed for smaller changes.

Starting out

  • Subscribe to the request dash sponsor at opensolaris dot org mailing list and check out the pending requests that are still waiting for a sponsor. There is also a Open HA Cluster specific page which just lists the OHAC related requests.
  • When a request for sponsorship comes by which matches your interest, experience and availability, reply-all that you are volunteering to be the sponsor for that request, then take further discussion off-line with the contributor. Keep the contributor copied on just about all subsequent discussion in the steps below.
  • Become familiar with the steps the contributor should perform and their instructions, so you can best gauge how to guide them.
  • Verify that the contributor has a signed Sun Contributor Agreement (SCA). Verify the OS0XXX number and make sure its getting added to the OHAC related requests page. If you don't know where to verify the SCA, contact an existing core contributor who works for Sun to get advice.
  • Check the pre-requisites with the contributor:
    • Basic Solaris knowledge
    • Basic Solaris Cluster knowledge
    • In case the CR is related to a data service, basic application knowledge
    • Access to at least a single-node cluster to develop and test on with the necessary software installed. This single-node cluster could also run within an virtualization environment like VirtualBox, VMWARE Workstation, Parallels, etc. It is important to be able to reproduce the problem that is described in the CR that the contributor volunteered for.
    If you find gaps, try to provide pointers to documentation to help the contributor to get started. If you expect the learning curve to be too big, suggest maybe finding a different CR to start contributing, which fits more with the existing knowledge.
  • Triage: bug/RFE/project?
    • For data services, verify if there is already an umbrella project for this agent. If not, start proposing one on the ha dash clusters dash discuss at opensolaris dot org mailing list. If a project already exists, coordinate with the project owner to track the CR on the corresponding project web page.
    • For other working areas, determine if the change is big enough to require a project. If so, document and track the CR on the project web page.
  • Filing/updating bugs
    • Add “oss-sponsor” to the keyword list.
    • Put your e-mail address in Hook 5.
    • Put the contributor's e-mail address in Hook 6.
    • The name of the contributor should be listed somewhere in the bug report, preferably in the Evaluation and/or Suggested Fix text as appropriate.
    • Mark yourself as the Responsible Engineer. Note that if this field is already filled in, then you should contact the RE and decide whether s/he should take over sponsorship instead, or if the RE should pass the bug on to you, or perhaps some other arrangement.
    • Notify the contributor of changes in the bug report as needed. Refer the contributor to the public bug report on bugs.opensolaris.org. Do not forward any e-mail updates from Bugster, as they may contain Sun confidential information.

Develop, Test, Repeat

  • Encourage contributor to subscribe to ha dash clusters dash discuss at opensolaris dot org. Code review and technical discussion should happen there.
  • Coordinate with technology owner(s).
  • Help determine ideal design reviewers (if needed).
  • CLARC review (if needed):
    • The contributor should write the case, but may need help if s/he is inexperienced with the CLARC (which nearly all contributors will be at the beginning).
    • Find a sponsor.
    • Copy the contributor when submitting case(s), and make sure s/he is involved in any ensuing discussion.
  • Provide SCCS delta comment when requested.
    • Check before providing actual deltas, as old deltas might be encumbered.
  • Assist the contributor with running builds if needed. Also, note that you will be doing the putback yourself, so you should apply the patch to a workspace of your own and run nbuild on it.
  • Assist the contributor in determining what test suites should be run, running them if needed (not all are available externally), etc. And again, since you will be doing the putback, test this as thoroughly as you would test a wad of your own.

Getting ready to integrate

  • Help determine ideal code reviewers.
  • Per the CDDL block text, the contributor may add a comment 
    /* Portions Copyright YYYY Firstname Lastname */
    in the copyright section following the CDDL block at the top of the file. And regardless of whether such a comment is added or not, the Sun copyright should be updated appropriately.
  • Since the contributor's name and e-mail address are listed in the bug report, the SCCS delta comment should be the usual bug-ID and synopsis plus any ARC cases: the contributor's name should not be listed.
  • Insure the contributer has a valid SCA on file (Sun internal listing).
  • Filing RTIs
    • Select a good RTI advocate.
    • List the contributor in the Cc: field.
    • A SCA (Sun Contributor Agreement) must be on file for the contributor. The list of contributor agreements is posted internally; someone on the OpenSolaris team such as Linda Bernal would be good to check with about this.
    • The Third Party Source question on the WebRTI form must be answered with the name of the contributor and the associated SCA#. With this information cited, no further diligence related to the contribution will be required.

Putting Back

  • As opposed to the SCCS delta comment, the putback comment should have an additional line, of one of the following two formats, either: 
    Contributed by Firstname Lastname.
    or 
    Contributed by Firstname Lastname <something at example dot com>.
    Which format to use is up to the contributor.
  • Forward the putback message to the contributor.
  • Coordinate any ongoing issues with gate-keepers.

Monitoring Progress

After two months of inactivity on the CR, contact the contributor to check if s/he is still interested in working on it. If not, document the progress achieved so far and put the CR in a state so it can get found through the oss-byte-size keyword by other contributors again. Also make sure that the state is reflected on the pending requests and OHAC related requests pages.